Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove call to deprecated os.tmpDir (#2802) #2818

Merged
merged 1 commit into from
May 23, 2017

Conversation

makepanic
Copy link
Contributor

fixes #2802

os.tmpdir was added in 0.9.9 (see hapijs/hapi#3369).
With mocha having a minimum node version of 0.10 it can be dropped without issues.

@jsf-clabot
Copy link

jsf-clabot commented May 22, 2017

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.288% when pulling 3e7152f on makepanic:issue/2802 into e249434 on mochajs:master.

@ScottFreeCode ScottFreeCode merged commit fc35691 into mochajs:master May 23, 2017
@ScottFreeCode
Copy link
Contributor

Thanks!

@dasilvacontin
Copy link
Contributor

This fix has been released in v3.4.2! 🎉

sgilroy pushed a commit to TwineHealth/mocha that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warning in Mocha's test
5 participants